search

aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.96k stars 557 forks source link

Conflict in Peer Dependencies for @aws-sdk/client-sts @aws-sdk/client-secrets-manager #6098

Closed Callenowy closed 1 month ago

Callenowy commented 1 month ago

Checkboxes for prior research

Describe the bug

When installing the following packages:

npm i @aws-sdk/client-secrets-manager @aws-sdk/client-sts

The installation process results in conflicting peer dependencies.

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @aws-sdk/credential-provider-web-identity@3.575.0
npm WARN Found: @aws-sdk/client-sts@3.576.0
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   @aws-sdk/client-sts@"*" from the root project
npm WARN   3 more (@aws-sdk/client-secrets-manager, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/credential-provider-web-identity@3.575.0
npm WARN node_modules/@aws-sdk/credential-provider-web-identity
npm WARN   @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/credential-provider-ini@3.576.0
npm WARN   node_modules/@aws-sdk/credential-provider-ini
npm WARN   1 more (@aws-sdk/credential-provider-node)
npm WARN
npm WARN Conflicting peer dependency: @aws-sdk/client-sts@3.575.0
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/credential-provider-web-identity@3.575.0
npm WARN   node_modules/@aws-sdk/credential-provider-web-identity
npm WARN     @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/credential-provider-ini@3.576.0
npm WARN     node_modules/@aws-sdk/credential-provider-ini
npm WARN     1 more (@aws-sdk/credential-provider-node)

SDK version number

@aws-sdk/client-secrets-manager@3.576.0, @aws-sdk/client-sts@3.576.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v21.7.2

Reproduction Steps

  1. Run the npm i @aws-sdk/client-secrets-manager @aws-sdk/client-sts
  2. Observe the warning messages related to peer dependencies.

Observed Behavior

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @aws-sdk/credential-provider-web-identity@3.575.0
npm WARN Found: @aws-sdk/client-sts@3.576.0
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   @aws-sdk/client-sts@"*" from the root project
npm WARN   3 more (@aws-sdk/client-secrets-manager, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/credential-provider-web-identity@3.575.0
npm WARN node_modules/@aws-sdk/credential-provider-web-identity
npm WARN   @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/credential-provider-ini@3.576.0
npm WARN   node_modules/@aws-sdk/credential-provider-ini
npm WARN   1 more (@aws-sdk/credential-provider-node)
npm WARN
npm WARN Conflicting peer dependency: @aws-sdk/client-sts@3.575.0
npm WARN node_modules/@aws-sdk/client-sts
npm WARN   peer @aws-sdk/client-sts@"3.575.0" from @aws-sdk/credential-provider-web-identity@3.575.0
npm WARN   node_modules/@aws-sdk/credential-provider-web-identity
npm WARN     @aws-sdk/credential-provider-web-identity@"3.575.0" from @aws-sdk/credential-provider-ini@3.576.0
npm WARN     node_modules/@aws-sdk/credential-provider-ini
npm WARN     1 more (@aws-sdk/credential-provider-node)

Expected Behavior

The installation process should resolve peer dependencies without conflicts.

Possible Solution

No response

Additional Information/Context

No response

kuhe commented 1 month ago

I have confirmed the issue. I have temporarily marked @aws-sdk/client-sts@3.575.0 as latest on NPM to mitigate. As of now, the installation command should work.

We intend to release a patch for this later today.

trivikr commented 1 month ago

Reopening to verify fix after https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.577.0 is published, which is expected around 12:30 PM Pacific today.

trivikr commented 1 month ago

verify fix after v3.577.0 (release) is published

The v3.577.0 is published, and there's no failures with npm install anymore

$ npm i @aws-sdk/client-secrets-manager @aws-sdk/client-sts

$ npm ls @aws-sdk/client-sts
test-npm@1.0.0 /Users/trivikr/workspace/test-npm
├─┬ @aws-sdk/client-secrets-manager@3.577.0
│ ├─┬ @aws-sdk/client-sso-oidc@3.577.0
│ │ └── @aws-sdk/client-sts@3.577.0 deduped
│ ├── @aws-sdk/client-sts@3.577.0 deduped
│ └─┬ @aws-sdk/credential-provider-node@3.577.0
│   ├─┬ @aws-sdk/credential-provider-ini@3.577.0
│   │ └── @aws-sdk/client-sts@3.577.0 deduped
│   └─┬ @aws-sdk/credential-provider-web-identity@3.577.0
│     └── @aws-sdk/client-sts@3.577.0 deduped
└── @aws-sdk/client-sts@3.577.0

$ grep peerDependencies -A 2 node_modules/@aws-sdk/credential-provider-ini/package.json 
  "peerDependencies": {
    "@aws-sdk/client-sts": "^3.577.0"
  },
Callenowy commented 1 month ago

Beautiful, thank You! :)

github-actions[bot] commented 1 month ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.