fix(codegen): consistently add region as config option when generated client is Sigv4 but not AWS

aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.

Apache License 2.0

2.96k stars 556 forks source link

fix(codegen): consistently add region as config option when generated client is Sigv4 but not AWS #6156

Closed kuhe closed 3 weeks ago

kuhe commented 3 weeks ago

Issue

N/A, internal code generation

Description

The goal is to set the region configuration and all related codegen on a consistent condition, i.e. the service being either AWS service or being a Sigv4 service. (Non-AWS sigv4 services exist).

Testing

Restored unit tests removed in https://github.com/aws/aws-sdk-js-v3/pull/5497 (committed as https://github.com/aws/aws-sdk-js-v3/pull/5543/commits/6c9f9138742700720057381d29e3478c8467ba55 in https://github.com/aws/aws-sdk-js-v3/pull/5543)

github-actions[bot] commented 1 week ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.