aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.96k stars 556 forks source link

StartDate, EndDate and ScheduleExpressionTimeZone fields on PutRulesCommand #6158

Closed LuccaRebelloToledo closed 2 weeks ago

LuccaRebelloToledo commented 3 weeks ago

Describe the feature

Add the StartDate, EndDate, ScheduleExpressionTimeZone and FlexibleTimeWindow fields on PutRulesCommand

19094c64-9bdf-4fcf-809d-07722d82bb30

Use Case

I have a use case like others of recursion in scheduling notifications and the impact that when this notification starts and in the desired time zone. This would bring a lot of dynamism to the client event bridge

Proposed Solution

Other Information

No response

Acknowledgements

SDK version used

3.588.0

Environment details (OS name and version, etc.)

Windows Version 10.0.19045 Build 19045

aBurmeseDev commented 3 weeks ago

Hi @LuccaRebelloToledo - thanks for reaching out.

I see that you also created a PR. These models are generated by upstream service API and SDK team doesn't modify any generated models. What you're asking needs to reviewed and updated by service team (EventBridge) in this case. Once it's updated on service model, you'll be able to see it across SDK languages.

You can either submit a request via AWS Support or I can submit one on your behalf if you'd like. Hope that makes sense and let me know if you have any further questions.

LuccaRebelloToledo commented 3 weeks ago

Hi @aBurmeseDev

Thank you very much for your contact and for your explanation. Could you make the request on my behalf? I would be very grateful, if you need more information, I'm at your disposal! Thank you again very much and have a great day :)

aBurmeseDev commented 2 weeks ago

Submitted internal request to EventBridge (ref: P134937654)

embano1 commented 2 weeks ago

Just to check, are you requesting to have these EventBridge Scheduler features available in EventBridge PutRules to create schedules? If so, is there any reason why you can't use Scheduler? Scheduler is purpose-built for managing schedules, is the successor to EventBridge schedules on rules, and therefore we don't have plans to add new features to the scheduling capabilities in PutRule.

LuccaRebelloToledo commented 2 weeks ago

Hey Michael, how are you? I hope everything is fine :)

Based on what you said, I did my research and found client-scheduler and this library perfectly meets what I was requesting. I apologize for the lack of attention previously, but, as a user, when using the tool in the CLI, the first thing that comes to mind when downloading the SDK is to look for the event-bridge client and not the scheduler. At first, it seemed like it was a new event-bridge feature and not a new client/SDK. Anyway, thank you very much Michael, congratulations on the product!

embano1 commented 2 weeks ago

@LuccaRebelloToledo thx a ton, you rock!

github-actions[bot] commented 4 days ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.