What does this implement/fix? Explain your changes.
The documentation for the credentials option would lead you to think an explicit undefined or omitting the option would use the default credential provider, the current implementation only works for the latter scenario. Explicitly passing undefined uses the default provider in v2.
In the scenario that a user provides credentials: undefined in the config object, because it is spread at the end of the object, the defaulted properties are overwritten
Testing
How was this change tested?
Additional context
Add any other context about the PR here.
Checklist
[ ] If you wrote E2E tests, are they resilient to concurrent I/O?
[ ] If adding new public functions, did you add the @public tag and enable doc generation on the package?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Issue
Issue number, if available, prefixed with "#"
Description
What does this implement/fix? Explain your changes. The documentation for the credentials option would lead you to think an explicit undefined or omitting the option would use the default credential provider, the current implementation only works for the latter scenario. Explicitly passing undefined uses the default provider in v2.
In the scenario that a user provides
credentials: undefinedin the config object, because it is spread at the end of the object, the defaulted properties are overwrittenTesting
How was this change tested?
Additional context
Add any other context about the PR here.
Checklist
@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.