aws / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.
Apache License 2.0
2.95k stars 554 forks source link

test(protocoltests): add S3 Client #6178

Open trivikr opened 3 weeks ago

trivikr commented 3 weeks ago

Issue

Internal JS-5057

Description

Adds S3 client in RestXml Protocol tests

Testing

CI

Additional context

Previous attempt in https://github.com/aws/aws-sdk-js-v3/pull/5166


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr commented 3 weeks ago

CI failure is in build

src/S3Client.ts:312:58 - error TS2345: Argument of type 'S3ClientResolvedConfig' is not assignable to parameter of type 'S3ResolvedConfig'.
  Type 'SmithyResolvedConfiguration<HttpHandlerOptions> & Required<ClientDefaults> & RuntimeExtensionsConfig & ... 6 more ... & HttpAuthSchemeResolvedConfig' is missing the following properties from type 'S3ResolvedConfig': followRegionRedirects, s3ExpressIdentityProvider

312     this.middlewareStack.use(getValidateBucketNamePlugin(this.config));
                                                             ~~~~~~~~~~~

src/S3Client.ts:314:64 - error TS2345: Argument of type 'S3ClientResolvedConfig' is not assignable to parameter of type 'PreviouslyResolved'.
  Property 'followRegionRedirects' is missing in type 'SmithyResolvedConfiguration<HttpHandlerOptions> & Required<ClientDefaults> & RuntimeExtensionsConfig & ... 6 more ... & HttpAuthSchemeResolvedConfig' but required in type 'PreviouslyResolved'.

314     this.middlewareStack.use(getRegionRedirectMiddlewarePlugin(this.config));
                                                                   ~~~~~~~~~~~

  ../../packages/middleware-sdk-s3/dist-types/region-redirect-middleware.d.ts:7:5
    7     followRegionRedirects: boolean;
          ~~~~~~~~~~~~~~~~~~~~~
    'followRegionRedirects' is declared here.

src/auth/httpAuthSchemeProvider.ts:22:36 - error TS2307: Cannot find module '../endpoint/EndpointParameters' or its corresponding type declarations.

22 import { EndpointParameters } from "../endpoint/EndpointParameters";
                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/auth/httpAuthSchemeProvider.ts:23:41 - error TS2307: Cannot find module '../endpoint/endpointResolver' or its corresponding type declarations.

23 import { defaultEndpointResolver } from "../endpoint/endpointResolver";
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/auth/httpAuthSchemeProvider.ts:67:63 - error TS2344: Type 'TParameters' does not satisfy the constraint 'HttpAuthSchemeParameters'.

67 > extends HttpAuthSchemeParametersProvider<TConfig, TContext, TParameters, TInput> {}
                                                                 ~~~~~~~~~~~

src/runtimeConfig.ts:48:15 - error TS2339: Property 'disableS3ExpressSessionAuth' does not exist on type 'S3ClientConfig'.

48       config?.disableS3ExpressSessionAuth ?? loadNodeConfig(NODE_DISABLE_S3_EXPRESS_SESSION_AUTH_OPTIONS),
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 6 errors in 3 files.

Errors  Files
     2  src/S3Client.ts:312
     3  src/auth/httpAuthSchemeProvider.ts:22
     1  src/runtimeConfig.ts:48
error Command failed with exit code 2.