search

aws / aws-sdk-js

AWS SDK for JavaScript in the browser and Node.js
https://aws.amazon.com/developer/language/javascript/
Apache License 2.0
7.59k stars 1.55k forks source link

Error in AWS SDK and Usage Guide for Content Moderation version 7 #4589

Closed seantsangmk closed 6 months ago

seantsangmk commented 7 months ago

Describe the bug

I followed the instructions provided in the guide (https://docs.aws.amazon.com/rekognition/latest/dg/procedure-moderate-images.html#moderation-labels-update-sdk) to update the label mappings for Versions 6.1 to 7. However, this result in an error being displayed in CloudWatch.

Expected Behavior

interface DetectModerationLabelsRequest should include RequestedModelVersion

Current Behavior

cloudwatch log shows errors with UnexpectedParameter: Unexpected key 'RequestedModelVersion' found in params

Reproduction Steps

use sample code in https://d1m67pwji3rslw.cloudfront.net/guide/Guide_JavaScriptV2.pdf with aws-sdk@2.1563.0

Possible Solution

No response

Additional Information/Context

No response

SDK version used

2.1563.0

Environment details (OS name and version, etc.)

Windows 10 Version 22H2 (OS Build 19045.3930)

tpneumat commented 7 months ago

Same issue -- aws-sdk version-- 2.264.1

hjst commented 6 months ago

@seantsangmk @tpneumat The RequestedModelVersion param isn't in the public SDK (and I suspect it never will be). The instructions say to download the SDK version linked on that page and use that instead of the public SDK in NPM.

We vendored this "private" SDK into our repo (using it only for Rekognition) and sure enough, the RequestedModelVersion param is there and it works as documented.

RanVaknin commented 6 months ago

Hi all,

@hjst seems to be correct. Additionally the doc you linked mentions:

Your account will remain on version 6.1 until March 4, 2024. If you wish to use version 6.1 beyond March 4, 2024, contact theAWS Support team by March 1, 2024 to request for an extension. We can extend your account to remain on version 6.1 until April 2, 2024. If we do not hear from you by March 1, 2024, your account will be automatically migrated to version 7.0 between March 4, 2024 and March 26, 2024.

Since we are past this date I assume the upstream service automatically applies content moderation v7.

This is a service related request and is not not something the AWS SDK team can address. If there are any other questions please let us know.

Thanks, Ran~

github-actions[bot] commented 6 months ago

This issue has not received a response in 1 week. If you still think there is a problem, please leave a comment to avoid the issue from automatically closing.