search

aws / aws-sdk-js

AWS SDK for JavaScript in the browser and Node.js
https://aws.amazon.com/developer/language/javascript/
Apache License 2.0
7.59k stars 1.55k forks source link

Announcement link in V2 EOL banner doesn't work #4617

Closed perpil closed 6 months ago

perpil commented 6 months ago

Describe the issue

In this banner, the announcement isn't linked:

image

I think you mean to point here: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-javascript-v2/

Also, I'm somewhat surprised that AWSJavaScriptSDK/latest still points at V2 and V3 is AWSJavaScriptSDK/v3/latest I would expect latest to point at V3.

Links

https://docs.aws.amazon.com/AWSJavaScriptSDK/latest

aBurmeseDev commented 6 months ago

Hi @perpil - thanks for catching that.

I'll check in with our doc team to update the link.

Also, I'm somewhat surprised that AWSJavaScriptSDK/latest still points at V2 and V3 is AWSJavaScriptSDK/v3/latest I would expect latest to point at V3.

I don't full understand what you're proposing here though, are you suggesting v3 URL should be https://docs.aws.amazon.com/AWSJavaScriptSDK/latest instead of https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/ ?

Best, John

perpil commented 6 months ago

I'd expect https://docs.aws.amazon.com/AWSJavaScriptSDK/latest to be an alias for https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/ but understand that that might be tricky since there wouldn't be a home for V2 and there is no https://docs.aws.amazon.com/AWSJavaScriptSDK/v2/latest/