search

aws / aws-sdk-net-extensions-cognito

An extension library to assist in the Amazon Cognito User Pools authentication process
Apache License 2.0
102 stars 49 forks source link

Add Caching to GetAssemblyFileVersion #108

Closed theobalestra closed 1 year ago

theobalestra commented 1 year ago

Issue #107

https://github.com/aws/aws-sdk-net-extensions-cognito/issues/107

This PR adds caching to the AssemblyFileVersion using System.Runtime.Caching to prevent making a call to fetch the assembly everytime

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

muhammad-othman commented 1 year ago

@mojotheo Thank you for creating this PR I believe this will help with the issue you've linked, but using System.Runtime.Caching seems like an overkill, especially that this value will never change again and we wont be using caching anywhere else. Can you update it to just use a static variable instead?

theobalestra commented 1 year ago

@muhammad-othman Updated! let me know if that looks good

theobalestra commented 1 year ago

Is there a timeline on when we can expect this to go in?

normj commented 1 year ago

Version 2.3.1 is out with this PR. Thanks for the PR!