aws / aws-sdk-net-extensions-cognito

An extension library to assist in the Amazon Cognito User Pools authentication process
Apache License 2.0
102 stars 49 forks source link

Include pdb and xml in NuGet package #118

Open GabrielHare opened 1 year ago

GabrielHare commented 1 year ago

Describe the feature

The NuGet packages for the standard AWS SDK include pdb and xml files. Doing the same for these extensions would be nice... but it's not urgent, since this is a small open source project.

Use Case

Debug and documentation support for programmers using NuGet dll.

Proposed Solution

Follow the same NuGet package creation process as the standard AWS SDKs.

Other Information

No response

Acknowledgements

AWS .NET SDK and/or Package version used

AWS SDK Extensions for .NET Standard 2.0 (compatible with .NET Framework 4.5) Version 2.4.1

Targeted .NET Platform

.NET Framework 4.5

Operating System and version

Ubuntu 22.04

ashishdhingra commented 1 year ago

The HLL are published in release mode and PDB files are not included to reduce the size of NuGet package. For AWSSDK.Core 3.7.106.35, inspecting the package in NuGet Package Explorer shows the contained PDB and XML files.

Needs review with the team.

ashishdhingra commented 1 year ago

Per discussion with team, we should have the XML file in NuGet package if it is generated. We should enable source link for symbol packages.