search

aws / aws-sdk-net-extensions-cognito

An extension library to assist in the Amazon Cognito User Pools authentication process
Apache License 2.0
102 stars 49 forks source link

fix: Restore public method signatures that do not take a cancellation token #120

Closed ashovlin closed 1 year ago

ashovlin commented 1 year ago

Issue #, if available: #119

Description of changes: PR #115 added cancellation tokens with defaults, but this breaks existing callers who do not recompile.

This adds back the previous signatures, calling into the new ones with a default token.

I built locally with this added to the csproj, no new errors (outside of the expected one due to the snk difference):

      <EnablePackageValidation>true</EnablePackageValidation>
      <PackageValidationBaselineVersion>2.4.0</PackageValidationBaselineVersion>

You can view the diff from 2.4.0 to 2.4.2 at https://github.com/aws/aws-sdk-net-extensions-cognito/compare/4e9f2fa...1f63d79?diff=split

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.