search

aws / aws-sdk-net-extensions-cognito

An extension library to assist in the Amazon Cognito User Pools authentication process
Apache License 2.0
102 stars 49 forks source link

#129 - Fix StartWithSrpAuthAsync called by Sync context #131

Closed swensorm closed 10 months ago

swensorm commented 10 months ago

Issue #, if available: https://github.com/aws/aws-sdk-net-extensions-cognito/issues/129

Description of changes: Fixed bug with StartWithSrpAuthAsync(InitiateSrpAuthRequest) that would result in a deadlock scenario if the method was called by a synchronous context (e.g. .Result called on the method).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

philasmar commented 10 months ago

I am confused as to why there are 2 PRs with differing commits. https://github.com/aws/aws-sdk-net-extensions-cognito/pull/131 and https://github.com/aws/aws-sdk-net-extensions-cognito/pull/130. Could you please close one and consolidate your changes into a single PR?

philasmar commented 10 months ago

I am closing this PR in favor of https://github.com/aws/aws-sdk-net-extensions-cognito/pull/130 which is using ConfigureAwait(false).