search

aws / aws-sdk-net-extensions-cognito

An extension library to assist in the Amazon Cognito User Pools authentication process
Apache License 2.0
102 stars 49 forks source link

Add .NET 4.5 target #41

Closed johncrn closed 2 years ago

johncrn commented 5 years ago

Add support for .NET 4.5 target framework:

It would be great if this package officially supported .NET 4.5 in future releases. The package is really useful but unfortunately we need to support some legacy customers with it.

Thanks for your consideration and this helpful package!

normj commented 3 years ago

I would rather us not add .NET Framework as an additional platform we support for this library. Seeing as you can use .NET Standard 2.0 in newer versions of .NET Framework and .NET Standard and Core have desktop app support I'm curious how critical this is.

johncrn commented 3 years ago

Hi @normj , no problems not merging this.

While this isn't a problem for us anymore, .NET Standard requires the .NET Framework 4.6.1 and you'd be surprised how many systems out there are still running 4.5/4.5.1.

Instead we've invested time & comms getting our customers upgraded to .NET 4.8 which circumvents the problem.

normj commented 2 years ago

We have no plans to add .NET Framework support. I worry if we take this PR we are adding an anchor on to this project that I don't want.