AWSSDK.DynamoDbV2 adds 2 seconds to Lambda cold starts

scionwest commented 5 years ago

If I bring the AWSSDK.DynamoDbV2 package into a netcoreapp3.0 project and deploy it to Lambda I'm seeing it increase my cold start times by 2 seconds.

I have an example project that can be used to reproduce this. You just need to deploy it using dotnet lambda deploy-serverless, insert the following JSON object into the DynamoDb table it generated and make a request to /accounts/838d18ec-127d-4c96-af67-0556a346c114

{
  Email = "foo@bar.com",
  Password = "f00",
  Id = "838d18ec-127d-4c96-af67-0556a346c114"
}

Expected Behavior

When adding your package to an existing project I would expect it to not increase cold-start times of my Lambda by 2 full seconds.

Current Behavior

I'm using the Convey Microservice framework instead of Microsoft's MVC framework for Rest services. Launching a Lambda with a Convey endpoint returning in-memory generated data takes 4.4 seconds on average for a cold-start. If I add the AWSSDK.DynamoDbV2 package and run a GetItem request against a DynamoDB table the cold-start increases from 4.4 seconds to between 6.5 and 7.1 seconds from my tests.

Warm starts don't seem to be an issue. I see an increase of about 15ms on warm starts which isn't bad.

Steps to Reproduce (for bugs)

Download reproducible
Run dotnet lambda deploy-serverless
Insert JSON object above into the DynamoDb table created
Make an HTTP GET request to the /accounts/838d18ec-127d-4c96-af67-0556a346c114 endpoint to cold-start the lambda and resolve the DynamoDb client.

Context

It's generally known the aspnetcore and Lambda are rough when it comes to cold-starts for public facing APIs. I've seen a lot of this being related to how aspnetcore handles it's dependency tree. Moving to another middleware framework for http request processing that is lighter weight helps with the cold-start. The point of this however is defeated when Amazon's SDK packages severely impact the cold-starts on their own.

Your Environment

AWSSDK.DynamoDBv2 version used: 3.3.101.84
Operating System and version: Windows 10.0.17763 on EC2
Visual Studio version: Visual Studio Community 2019 (16.3.5)
Targeted .NET platform: netcoreapp

.NET Core Info

.NET Core version used for development: 3.0.100
.NET Core version installed in the environment where application runs: Custom runtime produced by dotnet lambda deploy-serverless

Output of dotnet --info:


.NET Core SDK (reflecting any global.json):
Version:   3.0.100
Commit:    04339c3a26

Runtime Environment: OS Name: Windows OS Version: 10.0.17763 OS Platform: Windows RID: win10-x64 Base Path: C:\Program Files\dotnet\sdk\3.0.100\

Host (useful for support): Version: 3.0.0 Commit: 7d57652f33

.NET Core SDKs installed: 2.1.802 [C:\Program Files\dotnet\sdk] 2.2.402 [C:\Program Files\dotnet\sdk] 3.0.100 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed: Microsoft.AspNetCore.All 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.NETCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

* Contents of project.json/project.csproj:

netcoreapp3.0 true Lambda

klaytaybai commented 5 years ago

Thanks for the feedback on this issue. We would like to continue improving the modularity of our packages and improving build/cold start times. In this area, DynamoDB is certainly a high priority.

github-actions[bot] commented 2 years ago

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

aws / aws-sdk-net