search

aws / aws-sdk-net

The official AWS SDK for .NET. For more information on the AWS SDK for .NET, see our web site:
http://aws.amazon.com/sdkfornet/
Apache License 2.0
2.06k stars 855 forks source link

Mismatch between SDK and SDK's documentation for S3 #1653

Open ciceroneves opened 4 years ago

ciceroneves commented 4 years ago

Description

In AWS SDK .NET documentation it states the AmazonS3Config has the property name ConnectionLimit which inherited from Amazon.Runtime.ClientConfig When I try to set this value in my project using the lastest version of the SDK, the compiler says that this property does not exist

Link for documentation https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/S3/TS3Config.html

Reproduction Steps

Create a .net standard project Add the AWSSDK.S3 nuget package (version 3.3.111.20) Try to instantiate an AmazonS3Config object and set the ConnectionLimit property

new AmazonS3Config
{
    ConnectionLimit = 42
});

Logs

N/A

Environment

This is a :bug: bug-report

ashishdhingra commented 3 years ago

Looks like ConnectionLimit is only available for .NET Framework as indicated by code https://github.com/aws/aws-sdk-net/blob/7c88eeceb52869892adb1fe50c3f06c8f1a6b126/sdk/src/Core/Amazon.Runtime/_bcl/ClientConfig.cs#L170. However, documentation needs to properly indicate that it is framework specific. Hence added doc-apireference label.