search

aws / aws-sdk-php-laravel

A Laravel 5+ (and 4) service provider for the AWS SDK for PHP
http://aws.amazon.com/sdkforphp/
Apache License 2.0
1.64k stars 242 forks source link

Add Laravel 8 support #191

Closed Kussie closed 3 years ago

Kussie commented 3 years ago

Description of changes: Adds support for Laravel 8

Changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

flemzord commented 3 years ago

Laravel 8 is out :)

Kussie commented 3 years ago

All green and ready to go

likeadeckofcards commented 3 years ago

When will this be merged?

j-fulbright commented 3 years ago

+1

huangdijia commented 3 years ago

+1

sidigi commented 3 years ago

+1

SamRemis commented 3 years ago

This needs a changelog, once it is added, it shouldn't take long to merge

Kussie commented 3 years ago

@SamRemis This change is almost the same as the Laravel 7 support branch that was merged (Apart from version numbers). I can add the changes to the changelog.md if that is what you asking, but imho that should be done when a new version is tagged instead, which this is not doing. But regardless also added the exact changes made to the main comment, if you need something else to get this merged let me know and i will jump on it.

duellsy commented 3 years ago

@SamRemis Agree with @Kussie on this one, the CHANGELOG.md and the version number should only be bumped when the release is actually tagged, not as part of a PR, as it was with the 3.5.0 release: https://github.com/aws/aws-sdk-php-laravel/commit/7a3705461c06dc1ce8496fbf9b22ec96f769b3a7

Are you able to handle this? It's holding up a lot of Laravel 8 upgrades :)

duellsy commented 3 years ago

Also tagging @howardlopez for input as they did the last couple of tagged releases 👋

Cannonb4ll commented 3 years ago

Waiting for this as well 👍

martinduefrandsen commented 3 years ago

When will this be merged?

howardlopez commented 3 years ago

Version 3.6.0 has been released with the changes. We appreciate your work on this @Kussie!