search

aws / aws-sdk-php-laravel

A Laravel 5+ (and 4) service provider for the AWS SDK for PHP
http://aws.amazon.com/sdkforphp/
Apache License 2.0
1.64k stars 242 forks source link

Laravel environment match #196

Closed hailwood closed 9 months ago

hailwood commented 3 years ago

Description of changes: Since Laravel 5.7 where they added the default environment variables for AWS to the .env.example the region variable has been called AWS_DEFAULT_REGION, however this package by default looks for AWS_REGION and then falls back to us-east-1.

This PR adjusts the confirm file to first look for AWS_REGION else AWS_DEFAULT_REGION else us-east-1.

This is a non-breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

stakahashi commented 2 years ago

+1

stobrien89 commented 9 months ago

Hi @hailwood,

Apololgies for the lack of attention to this. AWS_DEFAULT_REGION is only used by the AWS CLI and we don't plan to support it here or in the SDK in order to avoid confusion. Let us know if you have any questions.