search

aws / aws-sdk-php-laravel

A Laravel 5+ (and 4) service provider for the AWS SDK for PHP
http://aws.amazon.com/sdkforphp/
Apache License 2.0
1.64k stars 242 forks source link

Laravel 9 support - Tagged release needed #210

Closed Sunhat closed 2 years ago

Sunhat commented 2 years ago

Hi @SamRemis This was mentioned in a closed ticket, but the merged PR for Laravel 9 needs to be tagged with a new release version e.g. 3.7.0, and I think you may have missed this 🥺🥺

Thanks!

EDIT:

Apologies - I see the L9 ticket is still open, and should've commented there. I mistakenly thought it was closed.

SamRemis commented 2 years ago

@Sunhat Thank you, sorry it was late last night for me when I merged that, I forgot. I'll take care of that now

SamRemis commented 2 years ago

@Sunhat, can you confirm for me that the latest release works for you? :) it released and downloaded okay on my end, just always good to hear a customer confirm

pkid169 commented 2 years ago

I can confirm I was able to install this on my freshly upgraded laravel 9 app now. Thanks!

(Fun story - I was upgrading my app to Laravel 9 late last night, and found out this package wasn't compatible, just around exactly around the same time @SamRemis was pushing his change. Overall, perfect timing 👌 )

SamRemis commented 2 years ago

Thanks @pkid169 :)

github-actions[bot] commented 2 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.