added support for Laravel 5.8+, no need to change env variable name now

aws / aws-sdk-php-laravel

A Laravel 5+ (and 4) service provider for the AWS SDK for PHP

http://aws.amazon.com/sdkforphp/

Apache License 2.0

1.64k stars 242 forks source link

added support for Laravel 5.8+, no need to change env variable name now #221

Closed bashar94 closed 1 week ago

bashar94 commented 1 year ago

Issue : #216

Description of changes: From Laravel 5.8 the provided example .env variables for configuring AWS settings have been changed a bit, for configuring the default region Laravel is using the AWS_DEFAULT_REGION key which was AWS_REGION before Laravel 5.8. Added support for all the Laravel versions here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bashar94 commented 1 year ago

@jeremeamia would you please check this PR?

Thanks

RanVaknin commented 1 week ago

Hi @bashar94 ,

Please read my comment on https://github.com/aws/aws-sdk-php-laravel/issues/216#issuecomment-2215387257

I'm going to go ahead and close this PR. Thanks again for taking the time and submitting a PR.

All the best, Ran~