aws / aws-sdk-php-laravel

A Laravel 5+ (and 4) service provider for the AWS SDK for PHP
http://aws.amazon.com/sdkforphp/
Apache License 2.0
1.64k stars 242 forks source link

Installing package for laravel 10 launches composer error #226

Closed FB-LilianaIturribarria closed 1 year ago

FB-LilianaIturribarria commented 1 year ago

Describe the bug

I saw that the package had support with laravel 10 so i tried to upgrade and i have errors regarding the compatibility.

Expected Behavior

It should install composer dependency correctly

Current Behavior

On composer install

` Problem 1

Reproduction Steps

you can either run composer install with the current version of this package "3.7" or you can install it from scratch "composer require aws/aws-sdk-php-laravel", both launches the same error

Possible Solution

No response

Additional Information/Context

No response

SDK version used

3.7

Environment details (OS name and version, etc.)

OS X Ventura 13.1, PHP 8.1.15

stobrien89 commented 1 year ago

Hi @FB-LilianaIturribarria,

Sorry for the confusion. To officially support Laravel 10, we need to upgrade our CI to run tests against it with php 8.1 and 8.2. We haven't yet cut a release that includes the PR we merged last night.

I've submitted a PR to update our CI and encountered some issues with Illuminate (which we also test against) and need a second opinion before we cut a release with official support. I'll let you know when we're ready to cut another release.

FB-LilianaIturribarria commented 1 year ago

Hi @FB-LilianaIturribarria,

Sorry for the confusion. To officially support Laravel 10, we need to upgrade our CI to run tests against it with php 8.1 and 8.2. We haven't yet cut a release that includes the PR we merged last night.

I've submitted a PR to update our CI and encountered some issues with Illuminate (which we also test against) and need a second opinion before we cut a release with official support. I'll let you know when we're ready to cut another release.

Thank you @stobrien89 i'll wait for it

stobrien89 commented 1 year ago

Hi @FB-LilianaIturribarria,

I've just created release 3.8.0, which includes support for Laravel 10. Please let us know if you have any more questions

github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.