search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Symfony 7 support #102

Closed victormacko closed 7 months ago

victormacko commented 9 months ago

Describe the feature

Hi there, Symfony 7 was released recently, and it would be super awesome if this package's composer.json file could also be updated with v7 support. Thank you for a really great package by the way -- it's very very nice!

Use Case

Symfony 7 is the latest major update to the framework, and without subsequent updates to packages such as this one, it means users of those packages cannot update their software accordingly.

Proposed Solution

Update references to symfony pacakges to include v7 in the composer.json file.

Other Information

No response

Acknowledgements

SDK version used

latest

Environment details (OS name and version, etc.)

OSX, latest

yenfryherrerafeliz commented 8 months ago

Hi @victormacko, thanks for opening this feature request. We will be looking into this soon.

Thanks!

rhyd42 commented 8 months ago

I have checked the return types for Symfony 7, and Aws\Symfony\DependencyInjection\Configuration::getConfigTreeBuilder() has the return type specified. Adding a return type will break backwards compatibility, so this would need to be a major version change (3.x).

For Symfony 6, an @return annotation can be added to suppress the deprecation, but this should not be done until a Symfony 7 compatible version is available.

yenfryherrerafeliz commented 8 months ago

Hi @rhyd42, we are also planing to deprecate PHP versions below than 7.2.5, so that adding a return type here will be fine, since support for function return type was added after PHP 7.

Thanks!

yenfryherrerafeliz commented 7 months ago

Hi @victormacko, @rhyd42, we have introduced support for Symfony 7 in the following release.

Please reach out if is there anything else we can help with.

Thanks!

github-actions[bot] commented 7 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.