Closed ttomdewit closed 7 months ago
This would be amazing :pray: , it's the last blocker for Symfony 7 upgrade
I am working on getting the tests to succeed since just the Composer changes won't cut it 😢.
I also noticed https://github.com/aws/aws-sdk-php-symfony/pull/81 where the modernisation of the tool is mentioned for PHP 8 support, I wonder if the same will happen here (I imagine so).
@ttomdewit Wow, 2 years old PR. Seems like this package is abandoned for good. I'll see how much work would fork take, as we want to go Symfony 7 this/next week
Seems one of these last week active forks could be a good candidate: https://github.com/aws/aws-sdk-php-symfony/forks?include=active&page=1&period=1mo&sort_by=stargazer_counts
Fork/work in progress: https://github.com/TomasVotruba/aws-sdk-php-symfony/pull/1
Fork/work in progress: TomasVotruba/aws-sdk-php-symfony#1
@TomasVotruba you work fast 😛
@ttomdewit Wow, 2 years old PR. Seems like this package is abandoned for good. I'll see how much work would fork take, as we want to go Symfony 7 this/next week
Yeah sadly, I am already considering alternatives (just use the PHP SDK without the Symfony bundle stuff or alternatively I've been told about https://async-aws.com/)
I have to be fast, so it's working today :)
Here is tagged package to try out https://packagist.org/packages/tomasvotruba/aws-sdk-php-symfony
Feedback is appreciated :+1:
I have to be fast, so it's working today :)
Here is tagged package to try out https://packagist.org/packages/tomasvotruba/aws-sdk-php-symfony
Feedback is appreciated 👍
Let me give it a try tomorrow. Will report back.
Nice one @TomasVotruba ! Any chance you're able to submit a PR so your changes can be part of the official repo? .. that way everyone can stay updated as other changes are contributed. Thank you for all your work & happy new year!
@victormacko Thanks, once this PR and the PHP 8.0 gets merged, I'd be happy to send PR. But I think this repo is abandoned past 2 years.
I have to be fast, so it's working today :)
Here is tagged package to try out https://packagist.org/packages/tomasvotruba/aws-sdk-php-symfony
Feedback is appreciated 👍
Looking good! There is a release happening soon at devizzent/cebe-php-openapi
so I used a dev tag for that one, but everything else is installing nicely and my QA tooling tells me we're solid 👍.
Man we need this terribly, thanks in advance
@mehmetsen80 Awesome! It's up and running past 3 weeks :+1:
https://github.com/aws/aws-sdk-php-symfony/pull/103#issuecomment-1878973379
@TomasVotruba Unfortunately, the composer require aws/aws-sdk-php-symfony has still conflicts for Symfony 7
aws/aws-sdk-php-symfony[2.1.0, ..., 2.2.2] require symfony/config ~2.3|~3.0|~4.0|~5.0 -> found symfony/config[v2.3.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.44, v5.0.0, ..., v5.4.31] but these were not loaded, likely because it conflicts with another require.
UPDATE: I see that it's on your packagist, hopefully it will be official soon!
Hi @ttomdewit, thanks for your contribution. We did create a new PR, based on this one, for addressing this and we also introduced other changes such as deprecating PHP versions below 7.2.5 and adding support for PHP 8 and up. Those new changes are now available in the following release.
So please folks reach out if you need anything else that we can help with.
Thanks!
Issue #, if available: Solves #102
Description of changes: Add 7 range to Composer file for Symfony related packages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.