search

aws / aws-sdk-php-symfony

Apache License 2.0
351 stars 89 forks source link

Symfony 4.0.0 compatibility #32

Closed vandromedae closed 6 years ago

vandromedae commented 6 years ago

(PHP7.2, symfony 4.0)

Trying to install but returns the follow error:

Your requirements could not be resolved to an installable set of packages.

Problem 1

Installation failed, reverting ./composer.json to its original content.

trickeyone commented 6 years ago

I'm betting that since Symfony v4 is a significant rebuild, that it's not just a matter of updating the dependencies. Are there any plans to upgrade the bundle to support Symfony v4?

brianfreytag commented 6 years ago

@trickeyone I don't see a reason why it would be a "significant rebuild" considering the core of Symfony4 remains unchanged. At worst, it'll just need some updated dependencies.

brianfreytag commented 6 years ago

@trickeyone

It wasn't quite as cut-n-dry as just updating the versions in composer.json. I had a do a few other tweaks to update the privacy of the services being created in AwsExtension.php. The Symfony services are being created dynamically for all of the different AWS tools. Up through 3.4, all services were defined as public unless explicitly told to be private. In 4.0, one of their biggest sweeping changes was to completely reverse this, rendering previously public services unavailable from the Container. This was the only break with this Bundle, so I took care if and put in a PR, and will await word from the maintainers of this bundle.