search

aws / aws-sdk-php-symfony

Apache License 2.0
351 stars 89 forks source link

Fix deprecated messages #5

Closed pzorn closed 8 years ago

pzorn commented 8 years ago

I know this was in a previous release. But was taken out to support version 2.3. Added check for the new method introduced 2.6. To remove over 200 deprecation message I was seeing in my 2.7 installation.

jeskew commented 8 years ago

Would it make more sense to just bump the version to 1.1 and require Symfony >= 2.6? Users running 2.3-2.5 would still pull down 1.0.2.

pzorn commented 8 years ago

Its your call. I have seen it both ways. But if you add the check then you don't have to back port another bug that needs to be fixed for both versions, to keep supporting 2.3.

jeskew commented 8 years ago

That's a good point, especially since 2.3 is still supported until 05/2016. Travis wasn't triggered on this PR for some reason, so I'm going to close and reopen to try to force it.