search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Fix deprecation for symfony/config 4.2+ #54

Closed bits4breakfast closed 5 years ago

bits4breakfast commented 5 years ago

Heavily inspired by https://github.com/symfony/maker-bundle/pull/324

bits4breakfast commented 5 years ago

It is currently failing tests with two very old PHP versions

bits4breakfast commented 5 years ago

hi @howardlopez - what's the process for submitting a new PR? Thanks!

howardlopez commented 5 years ago

@bits4breakfast - You can update this PR by simply committing to the branch to be merged. It will trigger a new round of Travis tests.

bits4breakfast commented 5 years ago

@howardlopez - thanks. But are tests going to fail again for those PHP 5.3? Are they still supported?

alegout commented 5 years ago

Hello,

any news?

howardlopez commented 5 years ago

The Travis builds are currently failing for the PHP 5.5 and 5.6 builds, which are still supported. Since it's a memory limit issue, we'll have to look into the configuration to make sure it's set up in such a way that it can actually pass.

howardlopez commented 5 years ago

Closing and re-opening PR to trigger fresh Travis CI build with new Travis file that was recently merged in.

alegout commented 5 years ago

thank you @bits4breakfast && @howardlopez