search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Avoid calling magic methods to support linting the DIC #64

Closed mpdude closed 4 years ago

mpdude commented 4 years ago

Symfony 4.4 added a lint:container command. This linting step fails for the aws.* services created on the fly by this bundle, because those calls will in fact be handled by a magic method:

https://github.com/aws/aws-sdk-php/blob/02131fd17c9b62f36993bb2da88dd624ce058179/src/Sdk.php#L476-L478

By calling the createClient method directly, we can avoid these errors.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mpdude commented 4 years ago

@howardlopez Does this make sense?

lugus commented 4 years ago

It's working great, thank you @mpdude and @howardlopez