search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Mark client as lazy for all Symfony versions #80

Closed greg0ire closed 2 years ago

greg0ire commented 2 years ago

The previous fix only impacted Symfony < 2.6.

Issue #, if available: none

Description of changes:

In #60 , I made the S3Client lazy, or so I thought, but it turns out this only applies to a code path I'm no longer interested in. In fact, I don't really think I was using such an ancient version at the time so I don't know what happened.

Anyway, making the S3Client lazy is important because it does expensive stuff in its constructor, like loading a huge php file.

2022-02-03_10-58

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

greg0ire commented 2 years ago

@SamRemis please review

SamRemis commented 2 years ago

This looks good - we have a few bigger things releasing today on the main SDK, so hopefully I can get this tagged and merged tomorrow.

Thanks for the contribution

SamRemis commented 2 years ago

@greg0ire, This should be released now :) please let me know if there are any issues. Sorry about the delay