aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Update aws-sdk-php to latest version #81

Closed egorzot closed 3 months ago

egorzot commented 2 years ago

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

SamRemis commented 2 years ago

Hi there @egorzot, Thanks for the PR. Right now, I'm gonna leave this hanging until I can merge it, which will be in after we deprecate 5.5-7.0 so that we can add the return types like you have in the ConfigurationTest file. Working on it, and we started a discussion here on that. I'm going to try to push for faster deprecation on this and the other aws-sdk-php-* repositories so that we can avoid dependency issues.

SamRemis commented 2 years ago

Once the deprecation is official, then we will be able to move forward with this and I'll give it a more in-depth review

alexbaileyuk commented 1 year ago

@SamRemis we are unable to use this wrapper for the Event Bridge functionality we need since the included SDK version does not have the \Aws\EventBridge namespace. Is this likely to be updated any time soon or should we consider removing the wrapper and just installing the SDK itself?

SamRemis commented 1 year ago

@alexbaileyuk Thanks for drawing this to my attention again. While the deprecation is moving along, it hasn't been officially announced yet; it looks like it will be soon. I'm inches away from having it officially approved, and I'm hoping to get it fast-tracked as much as I can. In the meantime, I'd happily accept a PR that uses #[\ReturnTypeWillChange] in place of the return types and any other non PHP 5.5 compatible code I may have missed.

alexbaileyuk commented 1 year ago

@SamRemis thanks for a speedy response. Unfortunately we are under some tight time constraints and are unable to contribute or wait for the update.

For now, we only use two or three services from the SDK so we have decided to install the SDK directly and create the service definitions for those few service clients ourselves sucha as:

services:
    membr.aws.s3_client:
        class: Aws\S3\S3Client
        factory: [ Aws\S3\S3Client, 'factory' ]
        arguments:
            - version: latest
              region: eu-west-1

    membr.aws.sqs_client:
        class: Aws\Sqs\SqsClient
        factory: [ Aws\Sqs\SqsClient, 'factory' ]
        arguments:
            - version: latest
              region: eu-west-1
yenfryherrerafeliz commented 3 months ago

Hi @egorzot, thanks for working on this. We have introduced the changes suggested on this PR in the following release. Please feel free to reach out for anything we may help with.

Thanks!