search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Inherit AWS_MERGE_CONFIG value from .env files #87

Closed Khez closed 2 years ago

Khez commented 2 years ago

Closes #77

Also invalidates #82

Khez commented 2 years ago

@SamRemis anything blocking this?

SamRemis commented 2 years ago

@SamRemis anything blocking this?

Just commented on the PR. If you want to discuss the line limit, I'm happy to hear other opinion. I think in the next version of the SDK I'd like to ignore line limit lengths on error warnings, but for now it's how our code looks.

If you make the change, I can go ahead and merge/release this

Khez commented 2 years ago

Done and done!

The only thing that had me wondering was: Would it make more sense to change 3.0.0 to a future release in the deprecation message ?

Other than that, we're golden!

Khez commented 2 years ago

@SamRemis anything else that might be blocking this ?

We're using a composer post install/update hook to apply this exact patch so we don't get any warnings during our pipeline.

But I'd much rather update to "aws/aws-sdk-php-symfony": "2.5.0" 😃