search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Add Symfony 6 compability #88

Closed evzzz closed 7 months ago

evzzz commented 2 years ago

Describe the bug

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Limenius\ReactBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

Expected Behavior

Always time

Current Behavior

show deprecation message

Reproduction Steps

upgrade you project for Symfony 5.4 / 6.0

Possible Solution

No response

Additional Information/Context

No response

SDK version used

2.5.0

Environment details (OS name and version, etc.)

MacOS

diegosch21 commented 2 years ago

Same here. In every request in my project, in the debug toolbar i see this deprecation: Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Aws\Symfony\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

tacman commented 2 years ago

Related: app.WARNING: Failed to generate ConfigBuilder for extension Aws\Symfony\DependencyInjection\AwsExtension. {"exception":"[object] (LogicException(code: 0): The node was expected to be an ArrayNode. This Configuration includes an edge case not supported yet. at /home/tac/ca/ac/vendor/symfony/config/Builder/ConfigBuilderGenerator.php:108)","extensionClass":"Aws\Symfony\DependencyInjection\AwsExtension"} []

yenfryherrerafeliz commented 1 year ago

Hi @evzzz, thanks for reporting this. I have added a needs-review label so we can investigate this further.

Thanks!

eman1986 commented 1 year ago

I see this library has a large range of which version of Symfony it supports, even though most of them are unsupported by Symfony. I wonder if that's why this issue is present? It's also kinda silly to support PHP 5.5 since PHP 8 is the lowest version supported by PHP, everything older than that is end of life. It kinda makes me nervous to use this library.

rhyd42 commented 1 year ago

Symfony 7 will be released in November, at which point these deprecations will become errors.

boskos-q commented 9 months ago

To chip in with deprecations

Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Aws\Symfony\DependencyInjection\AwsExtension" now to avoid errors or add an explicit @return annotation to suppress this message.

@SamRemis what are the plans for pushing these fixes forward and deprecating old versions of php & symfony as discussed in #81 ? Thanks

janklan commented 9 months ago

Should the title be updated to Symfony 7 compatibility?

yenfryherrerafeliz commented 8 months ago

Hi @janklan, there is a feature request for Symfony 7 support already here. We will look at it soon. Please refer to that feature request for more updates.

Thanks!

janklan commented 8 months ago

Hey @yenfryherrerafeliz,

OK, thanks.

For the record, that PR was opened a few days after I asked the question.

yenfryherrerafeliz commented 7 months ago

Hi @diegosch21, @tacman, @eman1986, @rhyd42, @boskos-q, and @janklan, we have introduced support for Symfony 7 in the following release.

Please reach out if is there anything else we can help with.

Thanks!

github-actions[bot] commented 7 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.