search

aws / aws-sdk-php-symfony

Apache License 2.0
350 stars 89 forks source link

Specify in PHPDoc the return type of Configuration::getConfigTreeBuilder #95

Closed kaznovac closed 1 month ago

kaznovac commented 1 year ago

Issue #, if available: Resolves #88

Description of changes: Added the return type of TreeBuilder to the Configuration::getConfigTreeBuilder to avoid the following Deprecation notice:

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "Aws\Symfony\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

RanVaknin commented 1 month ago

Hi there,

It seems like this was already taken care of previously

https://github.com/aws/aws-sdk-php-symfony/blob/6ee6fc456d130df75ab747928382e462ea727e07/src/DependencyInjection/Configuration.php#L11

now getConfigTreeBuilder explicitly returns TreeBuilder

Thanks, Ran~