search

aws / aws-sdk-php-zf2

ZF2 module for using the AWS SDK for PHP to interact with AWS services like S3, DynamoDB, SQS, EC2, etc.
http://aws.amazon.com/sdkforphp/
Apache License 2.0
103 stars 63 forks source link

Zf sm3 compatibility #36

Closed basz closed 8 years ago

basz commented 8 years ago

Adds factory compatibility for zend-servicemanager 3

Note minimum requirement is now ^2.7 which might need to be reflected in composer

cjyclaire commented 8 years ago

Looks good to me, I'll double check with @jeremeamia who has more expertise in zf, does this looks good to you?

basz commented 8 years ago

soft ping

cjyclaire commented 8 years ago

LGTM, :shipit:

bakura10 commented 8 years ago

Would it be possible to tag this? :)

cjyclaire commented 8 years ago

Tagged! Thanks for the reminder :)

bakura10 commented 8 years ago

Thanks! ping @basz ;)

basz commented 8 years ago

thanks

cjyclaire commented 8 years ago

Apology for changing the tag. Version Tag has been changed to a minor version, since this could be breaking change for customer using 2.0.x.

basz commented 8 years ago

not a problem. thanks again

mikel5 commented 8 years ago

The change to AwsModule\Factory\AwsFactory is now incompatible with ZF2. The Service Manager in ZF2 isn't an instance of Interop\Container\ContainerInterface

cjyclaire commented 8 years ago

Ping here, composer dependency is fixed, and a new release is tagged, apology for tag changing.