search

aws / aws-sdk-php-zf2

ZF2 module for using the AWS SDK for PHP to interact with AWS services like S3, DynamoDB, SQS, EC2, etc.
http://aws.amazon.com/sdkforphp/
Apache License 2.0
103 stars 63 forks source link

Migrating to zf3 #45

Closed firelike closed 7 years ago

firelike commented 7 years ago

Hi, Changed FactoryInterface use statements and composer require statements.

cjyclaire commented 7 years ago

@firelike Appreciate your thoughts for this PR! Looks like a lot of dependency changes is happening, I'd need to gather some metric data to see the customer volume on those dependencies.

Also, the integration test is failing, we cannot take PR that fails the test. Finally, this change might requires version bump like v2.2.0 or v3.0.0 in order not to break other customers

firelike commented 7 years ago

@cjyclaire thank you! The bulk of the changes is around the use of "zend-version". It has previous version of "zend-json" (~2.5) as a requirement witch itself conflicts with "zend-json" 3.0.0. I tried to go around this by converting this dependency into config parameter. I can understand if this is not the best way to go. The integration test fails because it runs on php 5.5. The second integration test on 5.6 is OK. I changed composer to require 5.6 because this is a minimum requirement for zf3.

samsonasik commented 7 years ago

you can remove php 5.5 from .travis.yml if it will be going to at least php 5.6 for minimal php version.

firelike commented 7 years ago

@samsonasik thank you!

cjyclaire commented 7 years ago

Tagged release is out :)

jarrettj commented 7 years ago

👍