search

aws / aws-sdk-php-zf2

ZF2 module for using the AWS SDK for PHP to interact with AWS services like S3, DynamoDB, SQS, EC2, etc.
http://aws.amazon.com/sdkforphp/
Apache License 2.0
103 stars 63 forks source link

v3 is not compatible with zendframework/zend-filter #63

Closed sattes-faction closed 2 months ago

sattes-faction commented 4 years ago

Version of AWS SDK for PHP?

3.133.6

Version of AWS SDK ZF2 Module?

3.0.0

Version of ZF2?

"zendframework/zend-mvc": "~2.6.0",
"zendframework/zend-servicemanager": "~2.7.0",

Version of PHP (php -v)?

7.1

What issue did you see?

When using the S3RenameUpload-Filter I get a warning saying: "Warning: Declaration of AwsModule\Filter\File\S3RenameUpload::getFinalTarget($uploadData) should be compatible with Zend\Filter\File\RenameUpload::getFinalTarget($source, $clientFileName) in /platform/vendor/aws/aws-sdk-php-zf2/src/Filter/File/S3RenameUpload.php on line 12"

This ZF-change was introduced in https://github.com/zendframework/zend-filter/commit/f97d4160219ac831c7e3164f92bcdc3f637c5f41 - which was released with v.2.9.0 of "zendframework/zend-filter"

github-actions[bot] commented 3 months ago

We have noticed this issue has not recieved attention in 3 years. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.