aws / aws-sdk-php-zf2

ZF2 module for using the AWS SDK for PHP to interact with AWS services like S3, DynamoDB, SQS, EC2, etc.
http://aws.amazon.com/sdkforphp/
Apache License 2.0
103 stars 62 forks source link

v4 is not compatible with zend-servicemanager ^2.7.0 #67

Open devkokov opened 4 years ago

devkokov commented 4 years ago

Please fill out the sections below to help us address your issue.

Version of AWS SDK for PHP?

3.87.20

Version of AWS SDK ZF2 Module?

v4.1.0

Version of ZF2?

2

Version of PHP (php -v)?

7.1.33

What issue did you see?

Fatal error: Interface 'Zend\ServiceManager\Factory\FactoryInterface' not found in /var/www/vendor/aws/aws-sdk-php-zf2/src/Factory/DynamoDbSessionSaveHandlerFactory.php on line 16

Steps to reproduce

If you have a runnable example, please include it as a snippet or link to a repository/gist for larger code examples.

Additional context

Any additional information relevant to the issue, for example PHP/environment config settings if the issue is related to memory or performance. Using zendframework/zend-servicemanager 2.7.11, which is supposed to be supported from reading the composer.json file

devkokov commented 4 years ago

I realise now this is explained in the README, but maybe composer.json needs changing to reflect this i.e. from "zendframework/zend-servicemanager": "^2.7.0 || ^3.0", to "zendframework/zend-servicemanager": "^3.0",

ajredniwja commented 3 years ago

@devkokov I think that is expected behavior, and changing it might be a breaking change for some people. What do you think?

devkokov commented 3 years ago

It would be a breaking change for anyone using v2.7 of zendframework/zend-servicemanager, however in my experience this version of the service manager doesn't work with v4 of aws-sdk-php-zf2 anyway. (hence raising this issue) Unless I'm missing something