search

aws / aws-sdk-php

Official repository of the AWS SDK for PHP (@awsforphp)
http://aws.amazon.com/sdkforphp
Apache License 2.0
6.04k stars 1.23k forks source link

fix(MultipartUpload): changed ObjectURL for CompleteMultipartUpload into effectiveUri #2877

Closed idsulik closed 4 months ago

idsulik commented 9 months ago

Description of changes: I spent several hours to figure out why some files return ObjectURL with "%2F", but some files with "/", it turned out that CompleteMultipartUpload puts "Location" URL to ObjectURL while PutObject and CopyObject put the effectiveUri, changed this so CompleteMultipartUpload will return effecitveUri if it's available and "Location" if it's not available.

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

idsulik commented 9 months ago

Another way to fix it is to replace "%2F" with "/" for the location's URI, which one is preferable?

idsulik commented 7 months ago

@stobrien89 Hi! Should I do anything else or I just need to wait?

yenfryherrerafeliz commented 4 months ago

Hi @idsulik, thanks for opening this PR. This has been fixed already which you could confirm here. We just urldecoded to the Location param. Your suggested changes would be also another way to have this fixed, but by the time I had to fix an reported issue regarding this, I was not aware of this PR.

Closing this PR for now.

Thanks!