Open p8nut opened 3 months ago
Hi @p8nut,
Thanks for the contribution. Would you be able to to add some unit tests covering this behavior in Test\S3\StreamWrapperTest
? Nothing fancy, just assertions on the output.
as asked i try to add some basic test to the code but for some reason i wasn't able to try them on my computer. i leave them here for now and will try to validate all of them as soon as possible.
@p8nut,
Thanks for adding the tests. Just two things:
ReturnsFalse
to their names? e.g. testSetStreamOptionReturnsFalse
.$this->addMockResults(
$this->client,
[
new Result(),
]
);
prior to $stream = ...
in your tests.
Issue #, if available:
2954
Description of changes: this implement the missing functions from the stream wrapper interface. all of the missing function return false as the doc describe. if needed it also throw an E_WARNING
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.