search

aws / aws-sdk-php

Official repository of the AWS SDK for PHP (@awsforphp)
http://aws.amazon.com/sdkforphp
Apache License 2.0
6.04k stars 1.23k forks source link

Add support for psr/cache:^3.0 #3036

Closed issakujitsuk closed 2 days ago

issakujitsuk commented 4 days ago

Describe the feature

Currently, aws-sdk-php specifies psr/cache:^1.0 in the composer.json. Please add support for psr/cache:^3.0.

Use Case

I want to update web-token/jwt-library from version 3.3.x to 3.4.x, but I'm unable to do so because aws/aws-sdk-php locks psr/cache to version 1.0.

Proposed Solution

No response

Other Information

No response

Acknowledgements

SDK version used

3.324.13

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.2.8, Amazon Linux 2

yenfryherrerafeliz commented 4 days ago

Hi @issakujitsuk, thanks for this feature request. We will be open to accept a PR contribution for this, if you are willing to provide one? It will be something like:

"psr/cache": "^1.0 || ^2.0 || ^3.0",

Thanks!

issakujitsuk commented 3 days ago

Thank you for your replay, @yenfryherrerafeliz. Yes, I am willing to provide a pull request for this. I will work on it and submit it later.

github-actions[bot] commented 2 days ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

stobrien89 commented 2 days ago

Thanks for the contribution @issakujitsuk!

issakujitsuk commented 1 day ago

Thank you for merging as well, @stobrien89 😄