Closed alextwoods closed 8 months ago
Issue #, if available: Fixes #114
Description of changes: Adds configuration to change the behavior of SQS ActiveJob's handling of retries for exceptions from ActiveJobs.
The existing behavior does not follow the [https://guides.rubyonrails.org/active_job_basics.html#retrying-or-discarding-failed-jobs](Rails ActiveJob) retry/discard behavior which notes that failed jobs are not retried unless the jobs are configured otherwise.
To avoid this being a breaking change for existing users, the flag currently defaults to true (preserving the existing behavior).
true
Pending review, I will update the Readme to describe in more detail the interaction of SQS retry and Rails ActiveJob retries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: Fixes #114
Description of changes: Adds configuration to change the behavior of SQS ActiveJob's handling of retries for exceptions from ActiveJobs.
The existing behavior does not follow the [https://guides.rubyonrails.org/active_job_basics.html#retrying-or-discarding-failed-jobs](Rails ActiveJob) retry/discard behavior which notes that failed jobs are not retried unless the jobs are configured otherwise.
To avoid this being a breaking change for existing users, the flag currently defaults to
true(preserving the existing behavior).Pending review, I will update the Readme to describe in more detail the interaction of SQS retry and Rails ActiveJob retries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.