search

aws / aws-sdk-ruby

The official AWS SDK for Ruby.
https://aws.amazon.com/sdk-for-ruby/
Apache License 2.0
3.56k stars 1.22k forks source link

Aws::CloudSearchDomain::Client limits expression size #1181

Closed joshuasiler closed 8 years ago

joshuasiler commented 8 years ago

An undocumented limit of CloudSearch is that expression size (shown here http://docs.aws.amazon.com/cloudsearch/latest/developerguide/limits.html) is limited by half or more of the stated limit when using GET requests.

Gem should use POST by default, or at least have it as a configurable option. Any expression more than 4500 chars or so using this gem will fail with Aws::CloudSearchDomain::Errors::RequestEntityTooLarge, when the actual limit of the service is over 10K.

awood45 commented 8 years ago

This is currently defined in the model itself, so default choices would come from that. It would be interesting to explore what it would take to allow configuration of HTTP verbs used by service calls.

joshuasiler commented 8 years ago

Is it possible to change the default setting and just use POST across the board? A setting somewhere?

awood45 commented 8 years ago

Added to feature request backlog.

aladh commented 8 years ago

It looks like the java sdk implemented POST for CloudSearchDomain search requests. Would a similar implementation work for ruby? https://github.com/aws/aws-sdk-java/blob/fb1d42ee0e00dccf8a3290e04c367989ae5664fc/aws-java-sdk-cloudsearch/src/main/java/com/amazonaws/services/cloudsearchdomain/SwitchToPostHandler.java

joshuasiler commented 8 years ago

Yes this is exactly what is needed.

alexfarrill commented 7 years ago

+1 for this feature

cjyclaire commented 7 years ago

Soft ping, the feature PR has been merged, and will be tagged in today's release : )

joshuasiler commented 7 years ago

Great to hear

alexfarrill commented 7 years ago

thanks!