aws / aws-sdk-ruby

The official AWS SDK for Ruby.
https://aws.amazon.com/sdk-for-ruby/
Apache License 2.0
3.56k stars 1.22k forks source link

Gem displays deprecation warning in ruby 3.3 #2984

Open nathansamson opened 7 months ago

nathansamson commented 7 months ago

Describe the bug

When running the gem in ruby 3.3 it displays the following warning

/home/nathansamson/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/aws-sdk-core-3.191.1/lib/aws-sdk-core/assume_role_web_identity_credentials.rb:5: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of aws-sdk-core-3.191.1 to add base64 into its gemspec.

Expected Behavior

It should not do this

Current Behavior

It displays a warning in ruby 3.3

Reproduction Steps

Use the gem

Possible Solution

Include base64 in the gemspec

Additional Information/Context

No response

Gem name ('aws-sdk', 'aws-sdk-resources' or service gems like 'aws-sdk-s3') and its version

aws-sdk-core:3.191.1

Environment details (Version of Ruby, OS environment)

Ruby 3.3, linux

jterapin commented 7 months ago

Hi! Thank you for opening the ticket. We are planning to make an update to address this (TBD when).

github-actions[bot] commented 7 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

VitaliySerov commented 6 months ago

For history - this change is reverted by https://github.com/aws/aws-sdk-ruby/pull/2987

And basically ruby-3.3 have deprecation warning again

alextwoods commented 6 months ago

Adding these libraries (base64 and bigdecimal) as explicit dependencies causes issues for some existing users and so, to address that we rolled that change back to remove those dependencies.

We will need a comprehensive strategy to address support in 3.4 without causing breaking changes for existing cases.

mullermp commented 6 months ago

Re-opening for now.

nathansamson commented 6 months ago

Can we include conditional (based on the ruby version) dependencies in the gemspec file, or is that not supported?

mullermp commented 6 months ago

I don't believe so, we investigated doing that.