aws / aws-sdk

Landing page for the AWS SDKs on GitHub
https://aws.amazon.com/tools/
Other
71 stars 14 forks source link

TableWildcard option not supported with add-lf-tags-to-resource #128

Closed frco9 closed 2 months ago

frco9 commented 2 years ago

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug In the doc it is stated that :

At least one of TableResource$Name or TableResource$TableWildcard is required.

However when using the following command : aws lakeformation add-lf-tags-to-resource --resource '{ "Table": { "DatabaseName": "mydbname", "TableWildcard": {}}}' --lf-tags TagKey=mykey,TagValues=myvalue

I'm getting the following error :

An error occurred (InvalidInputException) when calling the AddLFTagsToResource operation: Table name cannot be empty.

The same command is working if I'm using a table name with "Name": "mytablename" instead of the TableWildcard

SDK version number aws-cli/2.2.16 Python/3.9.7 Darwin/20.5.0 source/x86_64 prompt/off

Platform/OS/Hardware/Device Mac OS 11.4

To Reproduce (observed behavior) aws lakeformation add-lf-tags-to-resource --resource '{ "Table": { "DatabaseName": "mydbname", "TableWildcard": {}}}' --lf-tags TagKey=mykey,TagValues=myvalue

Expected behavior

An error occurred (InvalidInputException) when calling the AddLFTagsToResource operation: Table name cannot be empty.

tim-finnigan commented 2 years ago

Hi @frco9, thanks for reaching out. I was able to reproduce this issue. Since this is a service issue that affects all SDKs, I’m transferring it to our shared SDK repository. I opened a ticket for the Lake Formation team and will update this issue when I hear back from them. Thank you for bringing this to our attention!

tim-finnigan commented 2 years ago

P53170585

prabavnc commented 2 years ago

Any updates on this issue?

tim-finnigan commented 2 years ago

Hi @prabavnc there was a recent update on our internal ticket that an engineer was going to follow up with the documentation team regarding this issue. I expect another update in the near future and will comment here when that happens.

tim-finnigan commented 2 months ago

Thanks all for your patience - we heard back from the service team regarding this issue, who noted that this is not likely to be addressed in the short term as this would technically by a backward incompatible chance for the API. Even though the service doesn't actually support it, it could still be a breaking change to remove it from the model. They could add documentation of this elsewhere but updating the model itself it unlikely to be possible in the short term. I will close this as not planned, and note that the service team did create a backlog item which could involve at least a documentation update.

github-actions[bot] commented 2 months ago

This issue is now closed.

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.