aws / aws-sdk

Landing page for the AWS SDKs on GitHub
https://aws.amazon.com/tools/
Other
68 stars 13 forks source link

(quicksight): add `paginateListGroups` Async Iterator #551

Closed moltar closed 11 months ago

moltar commented 1 year ago

Describe the feature

Would like to have the paginateListGroups Async Iterator function in the QuickSight client.

Other paginate* functions already exist, but paginateListGroups seems to be missing.

Use Case

To paginate.

Proposed Solution

Implement it.

Other Information

Acknowledgements

SDK version used

3.347.1

Environment details (OS name and version, etc.)

macOS, Node 16

RanVaknin commented 1 year ago

Hi @moltar ,

Thanks for letting us know. From what I can tell, non of the list operations for Groups has a paginator:

This is a problem with the service model itself. Even though QuickSight service supports pagination, there is no support for it in the model which means the SDK can't generate the paginators for it.

I have reached out to the service team internally in hopes that they can fix this.

Thanks, Ran~

P90870794

RanVaknin commented 11 months ago

Hi @moltar ,

Changes are now live. Thanks for your contribution :slightly_smiling_face:

All the best, Ran~

github-actions[bot] commented 11 months ago

This issue is now closed.

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

moltar commented 11 months ago

@RanVaknin is it released already? which version? Thanks.

RanVaknin commented 3 months ago

Hi @moltar ,

Did not see your comment.

Here is the paginator https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-quicksight/src/pagination/ListGroupsPaginator.ts

This should have been available since 3.376.0

Thanks Ran~