aws / aws-sdk

Landing page for the AWS SDKs on GitHub
https://aws.amazon.com/tools/
Other
68 stars 13 forks source link

Opensearch update-domain-config (instance count) #575

Closed Tjkent88 closed 8 months ago

Tjkent88 commented 11 months ago

Describe the issue

image It seems like this value controls data nodes rather than master nodes since the following controls that, can someone confirm?

image

Links

https://awscli.amazonaws.com/v2/documentation/api/latest/reference/opensearch/update-domain-config.html

tim-finnigan commented 11 months ago

Hi @Tjkent88 thanks for reaching out. I think you might be right that InstanceCount should refer to data nodes rather than master nodes. The update-domain-config CLI command maps to the UpdateDomainConfig API, and command documentation generally needs to be fixed upstream by service teams in order to reflected in the CLI/SDK documentation.

I'll transfer this issue to our cross-SDK repository and reach out to the OpenSearch documentation team to see if the wording here should be updated. For future reference you can also use the Provide feedback links at the bottom of these pages to directly contact the documentation team.

tim-finnigan commented 9 months ago

The documentation has now been updated in the API documentation but not the CLI documentation:

image

Sometimes there is a delay in the rollout of documentation updates — I can try checking in with the team. (ref: P101034143)

tim-finnigan commented 8 months ago

The CLI documentation has now been updated as well so I'll go ahead and close this. Thanks again for bringing this to our attention!

github-actions[bot] commented 8 months ago

This issue is now closed.

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.