search

aws / aws-sdk

Landing page for the AWS SDKs on GitHub
https://aws.amazon.com/tools/
Other
68 stars 12 forks source link

Add `--engine-arn` to `update-canary` #613

Closed socketbox closed 7 months ago

socketbox commented 9 months ago

Describe the feature

I'd like to see update-canary be capable of taking an --engine--arn argument that does what the Java and Go SDK are capable of with setEngineArn and SetEngineArn.

Use Case

When instantiating canaries outside of the AWS Console, either via IaC-related approaches or some other means, it's possible for the canary to become out-of-sync with its attendant Lambda function's latest version.

If there was a different use case that was behind the creation of the setEngineArn/SetEngineArn methods of the SDKs, then I'd think that same use case would apply here as well.

Proposed Solution

As mentioned, I think this could be as simple as adding an --engine-arn option to aws synthetics update-canary.

Other Information

No response

Acknowledgements

CLI version used

aws-cli/2.11.16 Python/3.11.3 Linux/6.2.0-33-generic

Environment details (OS name and version, etc.)

Linux/6.2.0-33-generic x86-64 Linux Mint 21.2

tim-finnigan commented 9 months ago

Hi @socketbox thanks for the feature request. The AWS CLI update-canary command corresponds to the UpdateCanary API. That API is maintained Amazon CloudWatch Synthetics service team, so we would need to forward feature requests like this to that team. They may have a reason for only allowing the setting of EngineArn via CreateCanary but we can try to find out more info. I'm going to transfer this to our cross-SDK repository, as service APIs are used across AWS SDKs and should have consistent behavior. (ref: P101834216)

tim-finnigan commented 7 months ago

We heard back from a member of the service team and they have added this feature request to their backlog. We cannot guarantee if or when the service team would implement this feature, but feel free to check back in the future for updates. We recommend reaching out through AWS Support if you have a support plan.

github-actions[bot] commented 7 months ago

This issue is now closed.

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.