search

aws / aws-sdk

Landing page for the AWS SDKs on GitHub
https://aws.amazon.com/tools/
Other
68 stars 12 forks source link

EXTERNAL_PROVIDER missing from UserStatusType #635

Closed walterholohan closed 2 months ago

walterholohan commented 8 months ago

Checkboxes for prior research

Describe the bug

EXTERNAL_PROVIDER is missing from the UserStatusType enum. Not sure if this is on purpose or a mistake. it is mentioned in the docs but is not in the list of valid values. We use EXTERNAL_PROVIDER within our code so do not want to upgrade SDK until I know if its a missing type issue or not

SDK version number

@aws-sdk/client-cognito-identity-provider@3.438.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

16.x

Reproduction Steps

Upgrade @aws-sdk/client-cognito-identity-provider to latest version and you will get a type error for EXTERNAL_PROVIDER in UserStatusType @

Observed Behavior

UserStatusType should have a value for EXTERNAL_PROVIDER

Expected Behavior

UserStatusType should have a value for EXTERNAL_PROVIDER

Possible Solution

No response

Additional Information/Context

No response

RanVaknin commented 8 months ago

Hi @walterholohan,

Thanks for opening this issue. I can confirm that indeed the EXTERNAL_PROVIDER enum value is not included in the SDK. It appears that the cognito identity service team have released this feature internally but did not release it through the SDK release system.

I have created an internal ticket with the service team.

I'm not sure how you are using this enum, but a simple workaround would be to just manually specify the string value "EXTERNAL_PROVIDER" instead.

Please check back occasionally to see if the service team has solved the issue. Thanks, Ran~

P104547519

pajohns commented 4 months ago

I noticed this omission of EXTERNAL_PROVIDER too. @RanVaknin this is certainly a workaround that you've suggested, but it was confusing for me as I would like to be able to map all available responses from AWS and this one was missing hence was throwing an exception when trying to map it to a matching domain model on my end.

flamewow commented 4 months ago

EXTERNAL_PROVIDER is missing in UserStatusType, but the JSDoc still contains it

image
RanVaknin commented 2 months ago

I have checked back with the service team and asked them to properly release the model change. Since this is not actionable by the SDK team, Im going to go ahead and close this ticket.

Please keep an eye on our release note to see when this has been updated.

Thanks again! Ran~

github-actions[bot] commented 2 months ago

This issue is now closed.

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

RanVaknin commented 1 month ago

This has now been released.