aws / aws-secretsmanager-caching-net

The AWS Secrets Manager .NET caching client enables in-process caching of secrets for .NET applications.
https://docs.aws.amazon.com/secretsmanager/latest/userguide/retrieving-secrets_cache-net.html
Apache License 2.0
55 stars 23 forks source link

Revert Microsoft.Extensions.Caching.Memory to 2.2.0 #144

Closed brianfeucht closed 4 months ago

brianfeucht commented 5 months ago

Due to some frustrating dependencies the update to Microsoft.Extensions.Caching.Memory causes a breaking issue with Kestrel on .NET 4.7.2. I can go into more details if it is useful but most important bit of information is we are stuck on version 2.2.0 of Microsoft.Extensions.Primitives library. The update made here forced this library to be updated through a transitive dependency.

Consumers of this library should be able to use a newer version by specifying it in their nuget package config without needing to force it here.

Would you consider reverting this change?

jbct commented 4 months ago

Hi @brianfeucht - are you able to take a dependency on v1.0.5?

brianfeucht commented 4 months ago

@jbct yes, v1.0.5 will work fine. Thank you.

jbct commented 4 months ago

Thanks for confirming, @brianfeucht. Closing.