Closed ankit-joinwal closed 1 year ago
Local build is failing due to Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.8:check (default-check) on project aws-secretsmanager-jdbc: The parameters 'rules' for goal org.jacoco:jacoco-maven-plugin:0.8.8:check are missing or invalid -> [Help 1]
Will check the build on PR if it fails there too, then the solution would be to specify code coverage rules like below
<execution>
<id>default-check</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
<configuration>
<rules>
<rule>
<element>PACKAGE</element>
<limits>
<limit>
<counter>LINE</counter>
<value>COVEREDRATIO</value>
<minimum>0.6</minimum>
</limit>
</limits>
</rule>
</rules>
</configuration>
</execution>
@umangnarwal Thanks for the suggestion. But i think there can be cases like this where SQLExceptions can be wrapped in non-SQL exceptions.
@willtong1234 , @simonmarty , @jpeddicord hoping to get review on this.
Resolved with #136
Issue #, if available: https://github.com/aws/aws-secretsmanager-jdbc/issues/113
Description of changes: While attempting to connect with database, sometimes the actual exception containing vendor code (1045) that denotes authentication failure is nested in outer exceptions. An example of such case is shown below:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.