search

aws / aws-sigv4-auth-cassandra-nodejs-driver-plugin

A SigV4 authentication client side plugin for the open-source DataStax NodeJS Driver for Apache Cassandra. Allows use of IAM users and roles.
Apache License 2.0
5 stars 16 forks source link

unify manual and credential chain credentials #5

Closed JoshRagem closed 3 years ago

JoshRagem commented 3 years ago

removed a credential resolution function that always returned undefined fetch (potentially cached) credentials when needed--at the challange

Issue #, if available: https://github.com/aws/aws-sigv4-auth-cassandra-nodejs-driver-plugin/issues/4

Description of changes: brings the manually submitted credentials and the default credentials onto the same level by leveraging AWS.CredentialProviderChain which will manage all issues of credential caching and retrieval for default (or externally configured) credential providers. added appropriate tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

JoshRagem commented 3 years ago

@bhouse99 no problem, is 1.0.3 the next version you want?

bhouse99 commented 3 years ago

I tested this against different configs, and I think I'll just merge in the branch and update the changes myself. :). Again thanks!

rizblie commented 2 years ago

Any reason why hasn't this version been released on npm?