search

aws / aws-step-functions-data-science-sdk-python

Step Functions Data Science SDK for building machine learning (ML) workflows and pipelines on AWS
Apache License 2.0
289 stars 88 forks source link

Customise Logging configuration #126

Open DyfanJones opened 3 years ago

DyfanJones commented 3 years ago

Hi all,

I was wondering whether it is possible to change the logging configuration when creating/updating a state machine. From my current understanding the loggging configuration is set to default:

https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/1e036cedd220dae3a41f1c875e9a522df9f75bb8/src/stepfunctions/workflow/stepfunctions.py#L212-L220

https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/1e036cedd220dae3a41f1c875e9a522df9f75bb8/src/stepfunctions/workflow/stepfunctions.py#L254-L258

wong-a commented 3 years ago

Hi @DyfanJones,

You're right. Workflow class doesn't expose a logging configuration parameter but there's no reason it shouldn't be in there as an optional parameter. By default, logging is off.

The API parameter is a dictionary (see boto3 docs) but there might be some abstraction we can do to help make it easier to set up.