search

aws / aws-step-functions-data-science-sdk-python

Step Functions Data Science SDK for building machine learning (ML) workflows and pipelines on AWS
Apache License 2.0
285 stars 87 forks source link

fix: make arns of all task resources aws-partition aware #131

Closed yuan-bwn closed 3 years ago

yuan-bwn commented 3 years ago

Issue #, if available: #120 Update: Resolve previous comments. Use boto3 patch mock for unit tests. Use f-string for string building. Create arn builder for providing integration resource arn. Create tests for arn builder.

Test: All unit tests and integ tests passed.

Description of changes: Support different aws partitions when SDK providing resource arns. Partitions will be determined by boto3 client session running region. Available regions are based on SFN regional availability. There are formatting changes for test_steps.py which done by IDE. They are valid changes and will not have functionality impact.

Test: Created new unit under test_steps suite. All units tests passed. All integration tests passed in both us-east-1 and cn-north-1 using test account.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

StepFunctions-Bot commented 3 years ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

wong-a commented 3 years ago

Released in v2.1.0: https://github.com/aws/aws-step-functions-data-science-sdk-python/releases/tag/v2.1.0